From 09f05f648f160a712c6b344bef9c574dd906726c Mon Sep 17 00:00:00 2001
From: Roland Conybeare <rconybeare@gmail.com>
Date: Sat, 27 Apr 2024 08:23:00 -0400
Subject: [PATCH] xo-unit: refactor: push nu_maker into detail namespace

---
 include/xo/unit/natural_unit.hpp | 24 +++++++++++++-----------
 utest/unit.test.cpp              |  2 +-
 2 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/include/xo/unit/natural_unit.hpp b/include/xo/unit/natural_unit.hpp
index b24cbc19..e51050f5 100644
--- a/include/xo/unit/natural_unit.hpp
+++ b/include/xo/unit/natural_unit.hpp
@@ -33,16 +33,18 @@ namespace xo {
             }
         }
 
-        template <typename Int>
-        struct nu_maker {
-            template <typename... Ts>
-            static constexpr natural_unit<Int>
-            make_nu(Ts... args) {
-                natural_unit<Int> bpu_array;
-                detail::push_bpu_array(&bpu_array, args...);
-                return bpu_array;
-            }
-        };
+        namespace detail {
+            template <typename Int>
+            struct nu_maker {
+                template <typename... Ts>
+                static constexpr natural_unit<Int>
+                make_nu(Ts... args) {
+                    natural_unit<Int> bpu_array;
+                    detail::push_bpu_array(&bpu_array, args...);
+                    return bpu_array;
+                }
+            };
+        }
 
         /** @class natural_unit
          *  @brief an array representing the cartesian product of distinct basis-power-units
@@ -64,7 +66,7 @@ namespace xo {
             constexpr natural_unit() : n_bpu_{0} {}
 
             static constexpr natural_unit from_bu(basis_unit bu) {
-                return nu_maker<Int>::make_nu(make_unit_power<Int>(bu));
+                return detail::nu_maker<Int>::make_nu(make_unit_power<Int>(bu));
             }
 
             constexpr std::size_t n_bpu() const { return n_bpu_; }
diff --git a/utest/unit.test.cpp b/utest/unit.test.cpp
index 6fb5041a..cb743694 100644
--- a/utest/unit.test.cpp
+++ b/utest/unit.test.cpp
@@ -40,7 +40,7 @@ namespace xo {
         using xo::qty::detail::bpu2_rescale;
         using xo::qty::detail::bpu2_product;
         using xo::qty::natural_unit;
-        using xo::qty::nu_maker;
+        using xo::qty::detail::nu_maker;
         using xo::qty::detail::su_product;
         using xo::qty::detail::su_bpu_product;
         using xo::qty::detail::nu_ratio_inplace;