From 33f96604ee9052f540fd428ee9c34a22d4d2528e Mon Sep 17 00:00:00 2001 From: Roland Conybeare Date: Wed, 27 Sep 2023 16:38:01 -0400 Subject: [PATCH] build: cosmetic: remove dead comments --- CMakeLists.txt | 48 -------------------------------------- src/reflect/CMakeLists.txt | 24 ------------------- 2 files changed, 72 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4ca908c6..407d67c6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -50,7 +50,6 @@ if(NOT CMAKE_INSTALL_RPATH) set(CMAKE_INSTALL_RPATH $(CMAKE_INSTALL_PREFIX)/lib CACHE STRING "runpath in installed libraries/executables") endif() - # early find_package() experiment find_package(indentlog CONFIG REQUIRED) find_package(refcnt CONFIG REQUIRED) @@ -66,54 +65,7 @@ add_subdirectory(utest) xo_export_cmake_config(${PROJECT_NAME} ${PROJECT_VERSION} ${PROJECT_NAME}Targets) -## ---------------------------------------------------------------- -## cmake export: -## -## populate .cmake files in $CMAKE_INSTALL_LIBDIR/cmake/reflect. -## cmake projects that include this directory in $CMAKE_PREFIX_PATH -## can use -## find_package(reflect REQUIRED) -## and -## target_link_libraries(${sometarget} PUBLIC reflect) -## to use the reflect library -# -#set(XO_PROJECT_CONFIG_VERSION "${XO_PROJECT_NAME}ConfigVersion.cmake") -#set(XO_PROJECT_CONFIG "${XO_PROJECT_NAME}Config.cmake") -# -#include(CMakePackageConfigHelpers) -# -## generates build/reflectConfigVersion.cmake -#write_basic_package_version_file( -# "${PROJECT_BINARY_DIR}/${XO_PROJECT_CONFIG_VERSION}" -# VERSION 0.1 -# COMPATIBILITY AnyNewerVersion -#) -# -## generates build/reflectConfig.cmake -#configure_package_config_file( -# "${PROJECT_SOURCE_DIR}/cmake/${XO_PROJECT_NAME}Config.cmake.in" -# "${PROJECT_BINARY_DIR}/${XO_PROJECT_CONFIG}" -# INSTALL_DESTINATION lib/cmake/${XO_PROJECT_NAME} -#) -# -## creates {reflectTargets.cmake, reflectTargets-noconfig.cmake} in $CMAKE_INSTALL_LIBDIR/cmake/reflect/ -## requires -## install(.. EXPORT reflectTargets ..) -## -#install( -# EXPORT ${XO_PROJECT_NAME}Targets -# DESTINATION lib/cmake/${XO_PROJECT_NAME} -#) -# -## creates {reflectConfigVersion.cmake, reflectConfig.cmake} in $CMAKE_INSTALL_LIBDIR/cmake/reflect/ -#install( -# FILES -# "${PROJECT_BINARY_DIR}/${XO_PROJECT_CONFIG_VERSION}" -# "${PROJECT_BINARY_DIR}/${XO_PROJECT_CONFIG}" -# DESTINATION lib/cmake/${XO_PROJECT_NAME}) - # ---------------------------------------------------------------- # install .hpp files xo_install_include_tree() -#install(DIRECTORY ${PROJECT_SOURCE_DIR}/include/reflect/ DESTINATION include/reflect) diff --git a/src/reflect/CMakeLists.txt b/src/reflect/CMakeLists.txt index bf709478..0b5c710e 100644 --- a/src/reflect/CMakeLists.txt +++ b/src/reflect/CMakeLists.txt @@ -22,32 +22,8 @@ xo_install_library2(${SELF_LIBRARY_NAME}) # ---------------------------------------------------------------- # dependencies: logutil, ... -#target_include_directories( -# ${SELF_LIBRARY_NAME} PUBLIC -# $ -# $ -#) - -#xo_refcnt_dependency(${SELF_LIBRARY_NAME}) -#xo_indentlog_dependency(${SELF_LIBRARY_NAME}) - -#add_dependencies(${SELF_LIBRARY_NAME} indentlog) -# note: can't use find_package() here, -# because find_package() needs to run successfully before -# dependency gets installed. xo_internal_dependency(${SELF_LIBRARY_NAME} indentlog) - -#target_link_libraries(${SELF_LIBRARY_NAME} PUBLIC indentlog) - xo_internal_dependency(${SELF_LIBRARY_NAME} refcnt) -#find_package(refcnt CONFIG REQUIRED) -##add_dependencies(${SELF_LIBRARY_NAME} refcnt) -#target_include_directories( -# ${SELF_LIBRARY_NAME} PUBLIC -# $ -# $ -#) -#target_link_libraries(${SELF_LIBRARY_NAME} PUBLIC refcnt) # ---------------------------------------------------------------- # 3rd party dependency: boost: