roland/xo-alloc
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xo-reader: refactor: streamline define_xs

Browse source
This commit is contained in:
Roland Conybeare 2024-08-18 23:33:32 -04:00
commit b607c8b6dc
2 changed files with 1 additions and 34 deletions
Download patch file Download diff file Expand all files Collapse all files

5
include/xo/reader/define_xs.hpp
View file

@ -74,11 +74,6 @@ namespace xo {
defexprstatetype defxs_type() const { return defxs_type_; }
bool admits_rightparen() const;
//bool admits_semicolon() const;
//bool admits_symbol() const;
// virtual void on_f64(..) override
virtual void on_expr(ref::brw<Expression> expr,
exprstatestack * p_stack,
rp<Expression> * p_emit_expr) override;

30
src/reader/define_xs.cpp
View file

@ -25,29 +25,6 @@ namespace xo {
def_expr_{std::move(def_expr)}
{}
bool
define_xs::admits_rightparen() const {
switch (defxs_type_) {
case defexprstatetype::def_0:
case defexprstatetype::def_1:
case defexprstatetype::def_2:
case defexprstatetype::def_3:
case defexprstatetype::def_4:
case defexprstatetype::def_5:
case defexprstatetype::def_6:
return false;
case defexprstatetype::invalid:
case defexprstatetype::n_defexprstatetype:
/* unreachable */
assert(false);
return false;
}
return false;
}
void
define_xs::on_expr(ref::brw<Expression> expr,
exprstatestack * /* p_stack */,
@ -271,12 +248,7 @@ namespace xo {
constexpr const char * self_name = "exprstate::on_rightparen";
if (!this->admits_rightparen())
{
this->illegal_input_error(self_name, tk);
}
assert(false); /* inserting this during refactor..? */
this->illegal_input_error(self_name, tk);
}
void