From a373b8da21fbd8e70bc66ef585a96d71874920c5 Mon Sep 17 00:00:00 2001
From: Roland Conybeare <rconybeare@gmail.com>
Date: Tue, 11 Nov 2025 10:05:55 -0500
Subject: [PATCH] xo-imgui: refactor ex4a: create_frame_buffers()

---
 xo-imgui/example/ex4a/VulkanApp.cpp | 23 ++++++++++++++++++++
 xo-imgui/example/ex4a/VulkanApp.hpp | 33 ++++++++---------------------
 2 files changed, 32 insertions(+), 24 deletions(-)

diff --git a/xo-imgui/example/ex4a/VulkanApp.cpp b/xo-imgui/example/ex4a/VulkanApp.cpp
index 1b178e41..d6ad73e9 100644
--- a/xo-imgui/example/ex4a/VulkanApp.cpp
+++ b/xo-imgui/example/ex4a/VulkanApp.cpp
@@ -286,4 +286,27 @@ MinimalImGuiVulkan::create_render_pass()
     }
 }
 
+void
+MinimalImGuiVulkan::create_framebuffers()
+{
+    framebuffers_.resize(swapchain_image_views_.size());
+
+    for (size_t i = 0; i < swapchain_image_views_.size(); i++) {
+        VkImageView attachments[] = { swapchain_image_views_[i] };
+
+        VkFramebufferCreateInfo framebuffer_info{};
+        framebuffer_info.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
+        framebuffer_info.renderPass = render_pass_;
+        framebuffer_info.attachmentCount = 1;
+        framebuffer_info.pAttachments = attachments;
+        framebuffer_info.width = swapchain_extent_.width;
+        framebuffer_info.height = swapchain_extent_.height;
+        framebuffer_info.layers = 1;
+
+        if (vkCreateFramebuffer(device_, &framebuffer_info, nullptr, &(this->framebuffers_[i])) != VK_SUCCESS) {
+            throw std::runtime_error("Failed to create framebuffer!");
+        }
+    }
+}
+
 /* end VulkanApp.cpp */
diff --git a/xo-imgui/example/ex4a/VulkanApp.hpp b/xo-imgui/example/ex4a/VulkanApp.hpp
index 11c20453..ae0f1dfd 100644
--- a/xo-imgui/example/ex4a/VulkanApp.hpp
+++ b/xo-imgui/example/ex4a/VulkanApp.hpp
@@ -62,26 +62,10 @@ private:
      */
     void create_render_pass();
 
-    void create_framebuffers() {
-        framebuffers.resize(swapchain_image_views_.size());
-
-        for (size_t i = 0; i < swapchain_image_views_.size(); i++) {
-            VkImageView attachments[] = { swapchain_image_views_[i] };
-
-            VkFramebufferCreateInfo framebufferInfo{};
-            framebufferInfo.sType = VK_STRUCTURE_TYPE_FRAMEBUFFER_CREATE_INFO;
-            framebufferInfo.renderPass = render_pass_;
-            framebufferInfo.attachmentCount = 1;
-            framebufferInfo.pAttachments = attachments;
-            framebufferInfo.width = swapchain_extent_.width;
-            framebufferInfo.height = swapchain_extent_.height;
-            framebufferInfo.layers = 1;
-
-            if (vkCreateFramebuffer(device_, &framebufferInfo, nullptr, &framebuffers[i]) != VK_SUCCESS) {
-                throw std::runtime_error("Failed to create framebuffer!");
-            }
-        }
-    }
+    /*
+     * populate @ref framebuffers_
+     */
+    void create_framebuffers();
 
     void create_command_pool() {
         VkCommandPoolCreateInfo poolInfo{};
@@ -333,7 +317,7 @@ private:
         VkRenderPassBeginInfo renderPassInfo{};
         renderPassInfo.sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
         renderPassInfo.renderPass = render_pass_;
-        renderPassInfo.framebuffer = framebuffers[imageIndex];
+        renderPassInfo.framebuffer = framebuffers_[imageIndex];
         renderPassInfo.renderArea.offset = {0, 0};
         renderPassInfo.renderArea.extent = swapchain_extent_;
 
@@ -398,10 +382,10 @@ private:
     }
 
     void cleanupFrameBuffers() {
-            for (auto framebuffer : framebuffers) {
+            for (auto framebuffer : framebuffers_) {
                 vkDestroyFramebuffer(device_, framebuffer, nullptr);
             }
-            framebuffers.clear();
+            framebuffers_.clear();
     }
 
     void cleanupImageViews() {
@@ -471,7 +455,8 @@ private:
 
     VkRenderPass render_pass_;
 
-    std::vector<VkFramebuffer> framebuffers;
+    std::vector<VkFramebuffer> framebuffers_;
+
     VkCommandPool commandPool;
     std::vector<VkCommandBuffer> commandBuffers;
     std::vector<VkSemaphore> imageAvailableSemaphores;