From 313c629a077ebeabc61fd616587790c6c0097ddb Mon Sep 17 00:00:00 2001
From: Roland Conybeare <rconybeare@gmail.com>
Date: Wed, 17 Dec 2025 20:16:46 -0500
Subject: [PATCH] xo-alloc2: DX1CollectorIterator infra [WIP]

---
 include/xo/facet/OObject.hpp |  2 +-
 include/xo/facet/obj.hpp     | 15 +++++++--------
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/include/xo/facet/OObject.hpp b/include/xo/facet/OObject.hpp
index 66ca997..08327d0 100644
--- a/include/xo/facet/OObject.hpp
+++ b/include/xo/facet/OObject.hpp
@@ -171,7 +171,7 @@ namespace xo {
              *  concerned.
              **/
             template <typename DOther>
-            DOther * downcast()
+            DOther * downcast() const
                 requires (std::is_same_v<DataType, DVariantPlaceholder>)
             {
                 if (data_ && (typeseq::id<DOther>() == this->iface()->_typeseq())) {
diff --git a/include/xo/facet/obj.hpp b/include/xo/facet/obj.hpp
index 2eed0bf..3849291 100644
--- a/include/xo/facet/obj.hpp
+++ b/include/xo/facet/obj.hpp
@@ -50,7 +50,13 @@ namespace xo {
             obj() {}
             explicit obj(Super::DataPtr d) : Super(d) {}
 
-            /** copy constructor **/
+            /** copy constructor
+             *
+             *  Intended for use cases:
+             *    obj<AFoo, DRepr> lhs = obj<AFoo, DRepr>   // same type on rhs
+             *    obj<AFoo> lhs = obj<AFoo, DRepr>          // variant lhs, typed rhs
+             *    obj<Afoo> lhs = obj<AFoo>                 // variant on both sides
+             **/
             template <typename DOther>
             obj(const obj<AFacet, DOther> & other)
                 requires (std::is_same_v<DRepr, DVariantPlaceholder>
@@ -98,13 +104,6 @@ namespace xo {
             static obj<AFacet, DRepr> mkobj(DRepr * data) { obj<AFacet, DRepr> x(data); return x; }
         };
 
-#ifdef DEPRECATED
-        template <typename AFacet, typename DRepr>
-        inline obj<AFacet, DRepr>
-        with_facet(DRepr * data) {
-            return obj<AFacet, DRepr>(data);
-        }
-#endif
     } /*namespace facet*/
 
     using facet::obj;