roland/xo-reader
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xo-reader2: intern for DDefineExpr lhs symbol

Browse source
This commit is contained in:
Roland Conybeare 2026-01-20 00:08:51 -05:00
commit 864a850825
2 changed files with 16 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

22
include/xo/expression2/DDefineExpr.hpp
View file

@ -25,6 +25,9 @@ namespace xo {
using TypeDescr = xo::reflect::TypeDescr;
public:
/** @defgroup scm-defineexpr-constructors **/
///@{
/** create instance: define-expr using memory from @p mm
* with lhs name @p lhs_name and rhs expression @p rhs_expr
**/
@ -35,14 +38,20 @@ namespace xo {
**/
static DDefineExpr * make_empty(obj<AAllocator> mm);
DDefineExpr(DVariable * lhs_var,
obj<AExpression> rhs);
///@}
/** @defgroup scm-definexpr-access-methods **/
///@{
DVariable * lhs() const { return lhs_var_; }
obj<AExpression> rhs() const noexcept { return rhs_; }
const DUniqueString * name() const noexcept;
void assign_lhs_name(const DUniqueString * name);
/** CONCESSION. will use DUniqueString* once we have StringTable **/
void assign_lhs_name(std::string_view name);
///@}
/** @defgroup scm-defineexpr-expression-facet **/
///@{
@ -55,10 +64,9 @@ namespace xo {
///@}
private:
DDefineExpr(DVariable * lhs_var,
obj<AExpression> rhs);
/** @defgrouop scm-defineexpr-instance-vars **/
///@{
private:
/** variable being defined by this expression.
**/
DVariable * lhs_var_ = nullptr;
@ -68,6 +76,8 @@ namespace xo {
obj<AExpression> rhs_;
// std::set<std::string> free_var_set_;
///@}
};
} /*namespace scm*/
} /*namespace xo*/

9
src/expression2/DDefineExpr.cpp
View file

@ -55,15 +55,6 @@ namespace xo {
lhs_var_->assign_name(name);
}
void
DDefineExpr::assign_lhs_name(std::string_view name)
{
scope log(XO_DEBUG(true), "bogus impl - will require unique string");
log && log(xtag("name", name));
//lhs_var_->assign_name(name);
}
void
DDefineExpr::assign_valuetype(TypeDescr td) noexcept
{