From 8f531065a9f5e8e8216a3df740cd62cd582d64c2 Mon Sep 17 00:00:00 2001
From: Roland Conybeare <rconybeare@gmail.com>
Date: Thu, 29 Jan 2026 15:12:00 -0500
Subject: [PATCH] xo-object2: implement APrintable for DArray

---
 xo-object2/CMakeLists.txt                     | 12 ++++++
 xo-object2/include/xo/object2/DArray.hpp      |  3 ++
 .../xo/object2/number/IGCObject_DFloat.hpp    |  1 +
 xo-object2/src/object2/CMakeLists.txt         |  1 +
 xo-object2/src/object2/DArray.cpp             | 41 +++++++++++++++++++
 5 files changed, 58 insertions(+)

diff --git a/xo-object2/CMakeLists.txt b/xo-object2/CMakeLists.txt
index 261b59df..83b24223 100644
--- a/xo-object2/CMakeLists.txt
+++ b/xo-object2/CMakeLists.txt
@@ -184,6 +184,18 @@ xo_add_genfacetimpl(
     OUTPUT_CPP_DIR src/object2
 )
 
+# note: manual target; generated code committed to git
+xo_add_genfacetimpl(
+    TARGET xo-object2-facetimpl-printable-array
+    FACET_PKG xo_printable2
+    FACET Printable
+    REPR Array
+    INPUT idl/IPrintable_DArray.json5
+    OUTPUT_HPP_DIR include/xo/object2
+    OUTPUT_IMPL_SUBDIR array
+    OUTPUT_CPP_DIR src/object2
+)
+
 # note: manual target; generated code committed to git
 xo_add_genfacetimpl(
     TARGET xo-object2-facetimpl-gcobject-array
diff --git a/xo-object2/include/xo/object2/DArray.hpp b/xo-object2/include/xo/object2/DArray.hpp
index 097b9a45..f50936e3 100644
--- a/xo-object2/include/xo/object2/DArray.hpp
+++ b/xo-object2/include/xo/object2/DArray.hpp
@@ -108,6 +108,9 @@ namespace xo {
             /** @defgroup darray-printable-methods **/
             ///@{
 
+            /** pretty-printing support **/
+            bool pretty(const ppindentinfo & ppii) const;
+
             ///@}
             /** @defgroup darray-gcobject-methods **/
             ///@{
diff --git a/xo-object2/include/xo/object2/number/IGCObject_DFloat.hpp b/xo-object2/include/xo/object2/number/IGCObject_DFloat.hpp
index b27163c2..a5a01fff 100644
--- a/xo-object2/include/xo/object2/number/IGCObject_DFloat.hpp
+++ b/xo-object2/include/xo/object2/number/IGCObject_DFloat.hpp
@@ -14,6 +14,7 @@
 #pragma once
 
 #include "GCObject.hpp"
+#include <xo/object2/number/GCObjectConversion_DFloat.hpp>
 #include <xo/gc/GCObject.hpp>
 #include <xo/alloc2/Allocator.hpp>
 #include "DFloat.hpp"
diff --git a/xo-object2/src/object2/CMakeLists.txt b/xo-object2/src/object2/CMakeLists.txt
index 2ea8a07f..609290e8 100644
--- a/xo-object2/src/object2/CMakeLists.txt
+++ b/xo-object2/src/object2/CMakeLists.txt
@@ -16,6 +16,7 @@ set(SELF_SRCS
     ISequence_Any.cpp
     ISequence_DArray.cpp
     ISequence_DList.cpp
+    IPrintable_DArray.cpp
     IPrintable_DList.cpp
     IPrintable_DBoolean.cpp
     IPrintable_DFloat.cpp
diff --git a/xo-object2/src/object2/DArray.cpp b/xo-object2/src/object2/DArray.cpp
index 1b4138c6..b1343a67 100644
--- a/xo-object2/src/object2/DArray.cpp
+++ b/xo-object2/src/object2/DArray.cpp
@@ -4,11 +4,16 @@
  **/
 
 #include "DArray.hpp"
+#include <xo/printable2/Printable.hpp>
+#include <xo/facet/FacetRegistry.hpp>
+#include <xo/indentlog/print/pretty.hpp>
 #include <xo/indentlog/print/tostr.hpp>
 #include <xo/indentlog/print/tag.hpp>
 #include <cstdint>
 
 namespace xo {
+    using xo::print::APrintable;
+    using xo::facet::FacetRegistry;
     using xo::mm::AGCObject;
     using xo::facet::typeseq;
 
@@ -62,6 +67,42 @@ namespace xo {
             }
         }
 
+        // printing support
+
+        bool
+        DArray::pretty(const ppindentinfo & ppii) const
+        {
+            using xo::print::ppstate;
+
+            ppstate * pps = ppii.pps();
+
+            if (ppii.upto()) {
+                /* perhaps print on one line */
+                pps->write("[");
+
+                for (size_t i = 0, n = this->size(); i < n; ++i ) {
+                    if (i > 0)
+                        pps->write(" ");
+
+                    obj<APrintable> elt
+                        = FacetRegistry::instance().variant<APrintable,AGCObject>(this->at(i));
+
+                    assert(elt.data());
+
+                    if (!pps->print_upto(elt))
+                        return false;
+
+                    ++i;
+                }
+
+                pps->write("]");
+                return true;
+            } else {
+                pps->write("[...]");
+                return false;
+            }
+        }
+
         // gc hooks for IGCObject_DArray
 
         std::size_t