From a346dcc5797c3ee04b46f6b1e139d7796cf83ad2 Mon Sep 17 00:00:00 2001
From: Roland Conybeare <rconybeare@gmail.com>
Date: Mon, 26 Jan 2026 21:36:10 -0500
Subject: [PATCH] xo-reader2: formatting + asserts

---
 src/reader2/DDefineSsm.cpp       |  9 +++++++--
 src/reader2/DExpectExprSsm.cpp   |  3 ++-
 src/reader2/DProgressSsm.cpp     | 24 ++++--------------------
 src/reader2/ParserStack.cpp      |  5 +++--
 src/reader2/SchematikaParser.cpp |  3 ++-
 utest/SchematikaParser.test.cpp  |  4 ++--
 6 files changed, 20 insertions(+), 28 deletions(-)

diff --git a/src/reader2/DDefineSsm.cpp b/src/reader2/DDefineSsm.cpp
index 0cd488e5..c4628c22 100644
--- a/src/reader2/DDefineSsm.cpp
+++ b/src/reader2/DDefineSsm.cpp
@@ -733,13 +733,18 @@ namespace xo {
         bool
         DDefineSsm::pretty(const ppindentinfo & ppii) const
         {
-            auto expr = FacetRegistry::instance().variant<APrintable,AExpression>(def_expr_);
+            auto expr
+                = FacetRegistry::instance().variant<APrintable,
+                                                    AExpression>(def_expr_);
+            assert(expr.data());
+            (void)expr;
 
             return ppii.pps()->pretty_struct
                 (ppii,
                  "DDefineSsm",
                  refrtag("defstate", defstate_),
-                 refrtag("def_expr", expr));
+                 refrtag("def_expr", expr)
+                    );
         }
     } /*namespace scm*/
 } /*namespace xo*/
diff --git a/src/reader2/DExpectExprSsm.cpp b/src/reader2/DExpectExprSsm.cpp
index 66eb41cd..7a82ad1c 100644
--- a/src/reader2/DExpectExprSsm.cpp
+++ b/src/reader2/DExpectExprSsm.cpp
@@ -336,7 +336,8 @@ namespace xo {
                 (ppii,
                  "DExpectExprSsm",
                  refrtag("allow_defs", allow_defs_),
-                 refrtag("cxl_on_rightbrace", cxl_on_rightbrace_));
+                 refrtag("cxl_on_rightbrace", cxl_on_rightbrace_)
+                    );
         }
 
 #ifdef NOT_YET
diff --git a/src/reader2/DProgressSsm.cpp b/src/reader2/DProgressSsm.cpp
index cc0fc14b..e085f8cf 100644
--- a/src/reader2/DProgressSsm.cpp
+++ b/src/reader2/DProgressSsm.cpp
@@ -1115,32 +1115,16 @@ namespace xo {
             if (rhs_)
                 rhs = FacetRegistry::instance().variant<APrintable,AExpression>(rhs_);
 
+            (void)lhs;
+
             return ppii.pps()->pretty_struct
                        (ppii,
                         "DProgressSsm",
                         refrtag("lhs", lhs),
                         refrtag("op", op_type_),
-                        cond(rhs, refrtag("rhs", rhs), "nullptr"));
+                        cond(rhs, refrtag("rhs", rhs), "nullptr")
+                           );
 
-#ifdef NOPE
-            if (ppii.upto()) {
-                return (ppii.pps()->print_upto("<progress_xs")
-                        && (lhs_ ? ppii.pps()->print_upto(refrtag("lhs", lhs_)) : true)
-                        && (op_type_ != optype::invalid ? ppii.pps()->print_upto(refrtag("op", op_type_)) : true)
-                        && (rhs_ ? ppii.pps()->print_upto(refrtag("rhs", rhs_)) : true)
-                        && ppii.pps()->print_upto(">"));
-            } else {
-                ppii.pps()->write("<progress_xs ");
-                if (lhs_)
-                    ppii.pps()->pretty(refrtag("lhs", lhs_));
-                if (op_type_ != optype::invalid)
-                    ppii.pps()->pretty(refrtag("op", op_type_));
-                if (rhs_)
-                    ppii.pps()->pretty(refrtag("rhs", rhs_));
-                ppii.pps()->write(">");
-                return false;
-            }
-#endif
         }
 
         obj<AExpression>
diff --git a/src/reader2/ParserStack.cpp b/src/reader2/ParserStack.cpp
index 91d8bca9..9af9f339 100644
--- a/src/reader2/ParserStack.cpp
+++ b/src/reader2/ParserStack.cpp
@@ -73,8 +73,9 @@ namespace xo {
                 char buf[80];
                 snprintf(buf, sizeof(buf), "[%lu]", i_frame);
 
-                auto ssm = FacetRegistry::instance().variant<APrintable,
-                                                             ASyntaxStateMachine> (frame->top());
+                auto ssm = (FacetRegistry::instance().variant
+                            <APrintable, ASyntaxStateMachine> (frame->top()));
+                assert(ssm.data());
 
                 pps->newline_pretty_tag(ppii.ci1(), buf, ssm);
 
diff --git a/src/reader2/SchematikaParser.cpp b/src/reader2/SchematikaParser.cpp
index 13f9edff..e584044c 100644
--- a/src/reader2/SchematikaParser.cpp
+++ b/src/reader2/SchematikaParser.cpp
@@ -117,7 +117,8 @@ namespace xo {
             return pps->pretty_struct
                        (ppii,
                         "SchematikaParser",
-                        refrtag("stack", psm_.stack()));
+                        refrtag("stack", psm_.stack())
+                           );
         }
     } /*namespace scm*/
 } /*namespace xo*/
diff --git a/utest/SchematikaParser.test.cpp b/utest/SchematikaParser.test.cpp
index a8544687..895aed10 100644
--- a/utest/SchematikaParser.test.cpp
+++ b/utest/SchematikaParser.test.cpp
@@ -16,9 +16,9 @@ namespace xo {
     using xo::scm::SchematikaParser;
     using xo::scm::ASyntaxStateMachine;
     using xo::scm::syntaxstatetype;
-    using xo::scm::DDefineSsm;
+//    using xo::scm::DDefineSsm;
     using xo::scm::DExpectExprSsm;
-    using xo::scm::defexprstatetype;
+//    using xo::scm::defexprstatetype;
     //using xo::scm::ParserResult;
     //using xo::scm::parser_result_type;
     using xo::scm::Token;