roland/xo-umbrella2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tidy: drop stale ACollector comments

Browse source
This commit is contained in:
Roland Conybeare 2026-05-02 13:58:22 -04:00
commit 200a027103
12 changed files with 4 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

4
xo-expression2/src/expression2/DGlobalSymtab.cpp
View file

@ -111,8 +111,6 @@ namespace xo {
{
scope log(XO_DEBUG(false), std::string_view(*var->name()));
//auto gc = mm.try_to_facet<ACollector>();
// It's possible there's already a global variable
// with the same name.
//
@ -197,8 +195,6 @@ namespace xo {
scope log(XO_DEBUG(true),
std::string_view(*tname->name()));
//auto gc = mm.try_to_facet<ACollector>();
auto ix = type_map_->find(tname->name());
if (ix == type_map_->end()) {

2
xo-expression2/src/expression2/DLocalSymtab.cpp
View file

@ -70,7 +70,6 @@ namespace xo {
DVariable * var = DVariable::make(mm, name, typeref, binding);
//auto gc = mm.try_to_facet<ACollector>();
vars_->push_back(mm, obj<AGCObject,DVariable>(var));
return binding;
@ -89,7 +88,6 @@ namespace xo {
} else {
obj<AGCObject> tname = DTypename::make(mm, name, type);
//auto gc = mm.try_to_facet<ACollector>();
types_->push_back(mm, tname);
}
}

3
xo-expression2/src/expression2/DSequenceExpr.cpp
View file

@ -72,9 +72,6 @@ namespace xo {
DSequenceExpr::push_back(obj<AAllocator> mm,
obj<AExpression> expr)
{
// null gc -> no write barrier
//obj<ACollector> gc = mm.try_to_facet<ACollector>();
if (expr_v_->size() == expr_v_->capacity()) {
/* reallocate+expand */

8
xo-gc/src/gc/GCObjectStore.cpp
View file

@ -346,8 +346,8 @@ namespace xo {
recd->upsert_cstr(mm, "n-live", DInteger::box(mm, 0));
recd->upsert_cstr(mm, "bytes", DInteger::box(mm, 0));
stats_v->assign_at(mm, //mm.try_to_facet<ACollector>(),
tseq.seqno(), obj<AGCObject,DDictionary>(recd));
stats_v->assign_at(mm, tseq.seqno(),
obj<AGCObject,DDictionary>(recd));
}
}
@ -392,8 +392,6 @@ namespace xo {
auto recd = stats_v->at(i);
if (recd) {
//obj<AAllocator> mm = mm.try_to_facet<ACollector>();
bool ok = final_stats_v->push_back(mm, recd);
assert(ok);
}
@ -451,8 +449,6 @@ namespace xo {
recd->upsert_cstr(mm, "n-live", DInteger::box(mm, 0));
recd->upsert_cstr(mm, "bytes", DInteger::box(mm, 0));
//obj<ACollector> gc = mm.try_to_facet<ACollector>();
stats_v->push_back(mm, obj<AGCObject,DDictionary>(recd));
}

5
xo-interpreter2/src/interpreter2/DVirtualSchematikaMachine.cpp
View file

@ -75,7 +75,8 @@ namespace xo {
// establish the set of types that mm_ will be able to collect
CollectorTypeRegistry::instance().install_types(retval.to_op().to_facet<ACollector>());
CollectorTypeRegistry::instance().install_types
(retval.to_op().to_facet<ACollector>());
return retval;
}
@ -821,8 +822,6 @@ namespace xo {
log && log(xtag("i_arg", i_arg), xtag("n_arg", args->size()), xtag("cap", args->capacity()));
//auto gc = mm_.to_op().to_facet<ACollector>();
args->push_back(mm_.to_op(), value);
i_arg = evalargs_frame->increment_arg();

1
xo-object2/include/xo/object2/DArray.hpp
View file

@ -203,7 +203,6 @@ namespace xo {
DArray *
DArray::array(obj<AAllocator> mm, Args... args)
{
//obj<ACollector> gc = mm.try_to_facet<ACollector>();
DArray * result = _empty(mm, sizeof...(args));
if (result) {
detail::do_array_push_back(result, mm, args...);

2
xo-object2/src/object2/DArray.cpp
View file

@ -4,7 +4,6 @@
**/
#include "DArray.hpp"
//#include "gc/RCollector_aux.hpp"
#include <xo/printable2/Printable.hpp>
#include <xo/facet/FacetRegistry.hpp>
#include <xo/indentlog/print/pretty.hpp>
@ -16,7 +15,6 @@ namespace xo {
using xo::print::APrintable;
using xo::facet::FacetRegistry;
using xo::mm::AGCObject;
//using xo::mm::mm_do_assign;
using xo::facet::typeseq;
namespace scm {

3
xo-object2/src/object2/DDictionary.cpp
View file

@ -148,7 +148,6 @@ namespace xo {
const DString * k1 = DString::from_cstr(mm, key_cstr);
if (k1) {
//obj<ACollector> gc = mm.try_to_facet<ACollector>();
return this->try_upsert(mm, std::make_pair(k1, value));
}
@ -181,8 +180,6 @@ namespace xo {
bool
DDictionary::upsert(obj<AAllocator> mm, const pair_type & kv_pair)
{
//obj<ACollector> gc = mm.try_to_facet<ACollector>();
if (this->try_update(mm, kv_pair))
return true;

1
xo-reader2/src/reader2/DApplySsm.cpp
View file

@ -233,7 +233,6 @@ namespace xo {
assert(expr_gco);
obj<AAllocator,DArena> mm(&(p_psm->parser_alloc()));
//auto gc = obj<AAllocator>(mm).try_to_facet<ACollector>();
if (args_expr_v_->size() == args_expr_v_->capacity()) {
// need to expand .args_expr_v_ capacity.

4
xo-reader2/src/reader2/DExpectFormalArglistSsm.cpp
View file

@ -201,8 +201,6 @@ namespace xo {
obj<AAllocator,DArena> mm(&parser_alloc);
DArray * argl_2x = DArray::_empty(mm, 2 * argl_->capacity());
//auto gc = obj<AAllocator>(mm).try_to_facet<ACollector>();
for (DArray::size_type i = 0, n = argl_->size(); i < n; ++i) {
// TODO: prefer non-bounds-checked access here
argl_2x->push_back(mm, argl_->at(i));
@ -212,8 +210,6 @@ namespace xo {
this->argl_ = argl_2x;
}
//auto gc = expr_alloc.try_to_facet<ACollector>();
this->argl_->push_back(expr_alloc, var_o);
}

2
xo-reader2/src/reader2/DExpectQArraySsm.cpp
View file

@ -178,8 +178,6 @@ namespace xo {
DExpectQArraySsm::on_quoted_literal(obj<AGCObject> lit,
ParserStateMachine * p_psm)
{
//auto gc = p_psm->expr_alloc().try_to_facet<ACollector>();
if(state_.code() == QArrayXst::code::qarray_1a) {
// append lit at the end of array_
{

2
xo-reader2/src/reader2/DGlobalEnv.cpp
View file

@ -85,8 +85,6 @@ namespace xo {
values_->resize(ix.j_slot() + 1);
}
//auto gc = mm.try_to_facet<ACollector>();
values_->assign_at(mm,
ix.j_slot(),
x);